Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset/client): allow use of enumsAsType config option #8472

Merged
merged 2 commits into from
Oct 13, 2022
Merged

feat(preset/client): allow use of enumsAsType config option #8472

merged 2 commits into from
Oct 13, 2022

Conversation

panusoi
Copy link
Contributor

@panusoi panusoi commented Oct 11, 2022

Description

Related #8471

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Confirmed locally that it resolves #8471

Test Environment:

  • OS: all
  • NodeJS: v14, v16
  • graphql version: 16.6.0
  • @graphql-codegen/cli: 2.13.6

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

🦋 Changeset detected

Latest commit: 12ed0dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@charlypoly charlypoly merged commit a08fb65 into dotansimha:master Oct 13, 2022
@bernharduw
Copy link

Thanks a lot @panusoi! I was literally coming here to report this as an issue, just to see you fixed it already 🥳!

@panusoi panusoi deleted the feat/client-preset-enums-as-types-config-option branch October 30, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enumsAsTypes can't be used with client-preset
3 participants