Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: handle global config.useTypeImports in graphql-modules #8486

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Oct 14, 2022

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

This PR take the config.useTypeImports into account for the graphql-modules plugin.

Related KitQL issue

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • 2 tests has been added for the CI. (and all previous tests are still passing)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation as it's taking care of a global config (it's not an additional one)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: b31df86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/graphql-modules-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@charlypoly charlypoly merged commit 08add4e into dotansimha:master Oct 17, 2022
@charlypoly
Copy link
Contributor

Thanks @jycouet! ⚡

It has been released in @graphql-codegen/graphql-modules-preset@2.5.3 📦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants