Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use gqlTagName in the autogenerated example #8995

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

charpeni
Copy link
Contributor

@charpeni charpeni commented Feb 15, 2023

Description

I noticed that the example generated wasn't using gqlTagName, and therefore the example said gql, but the recent version switched to graphql, and it got me confused for a second. I believe we probably want to leverage gqlTagName for the example and the other places already relying on it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

See updated snapshots and examples.

How Has This Been Tested?

  • Generated new examples via yarn generate:examples
  • Updated snapshots

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: 35e8b9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@n1ru4l
Copy link
Collaborator

n1ru4l commented Feb 16, 2023

@charpeni Thank you! Let us know when this is ready for review!

@n1ru4l
Copy link
Collaborator

n1ru4l commented Feb 16, 2023

@charpeni Can you please rebase upon the origin/master branch and then run yarn examples:codegen + commit the artifact changes?

@charpeni charpeni force-pushed the use-gqltagname-in-the-example branch from dc93e61 to d4df842 Compare February 16, 2023 14:03
@charpeni charpeni marked this pull request as ready for review February 16, 2023 14:04
@charpeni
Copy link
Contributor Author

Pull request rebased upon origin/master and marked as ready for review. 🎉

@n1ru4l
Copy link
Collaborator

n1ru4l commented Feb 16, 2023

@charpeni Don't forget to run yarn build before yarn examples:codegen, sorry!

@charpeni
Copy link
Contributor Author

@n1ru4l yes, I ran yarn install && yarn build before generating examples. It should be all good.

@n1ru4l n1ru4l force-pushed the use-gqltagname-in-the-example branch from d4df842 to 35e8b9e Compare February 16, 2023 17:48
@n1ru4l n1ru4l self-requested a review February 16, 2023 17:48
@charpeni
Copy link
Contributor Author

Ah, sorry! While working on another pull request, I just realized I was running yarn generate:examples and not yarn examples:codegen. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants