Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import and export statements in BaseResolversVisitor and ma… #9845

Merged
merged 7 commits into from Feb 20, 2024

Conversation

productdevbook
Copy link
Contributor

@productdevbook productdevbook commented Feb 20, 2024

fix: #7762

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

image

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 2e1dab0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@graphql-codegen/visitor-plugin-common Major
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/introspection Patch
@graphql-codegen/client-preset Patch
@graphql-codegen/graphql-modules-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@productdevbook
Copy link
Contributor Author

I've fixed everything, it would be great if we could publish this.

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have some tests for this? it would be great if we can add some tests around this to avoid future regressions. I suppose dev-tests would be a good addition

@productdevbook
Copy link
Contributor Author

I have attached the test.

@productdevbook
Copy link
Contributor Author

enumValues: {
          RoleStatus: '#changeName/server/drizzle/schema#RoleStatus',
        }

validation pr because enumValues does not occur successfully. i will soon commit

@productdevbook
Copy link
Contributor Author

Finish.

image

@saihaj
Copy link
Collaborator

saihaj commented Feb 20, 2024

thank you!

@saihaj saihaj merged commit 53f270a into dotansimha:master Feb 20, 2024
11 of 13 checks passed
@productdevbook productdevbook deleted the fix-split-type branch February 20, 2024 17:02
@saihaj
Copy link
Collaborator

saihaj commented Feb 20, 2024

released new version https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1708451740568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contextType path starts with "#"
2 participants