Excluded the __typename from the root node of subscriptions when using addTypenameSelectionDocumentTransform with documentTransforms #9889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __typename should not be added to the root node of a subscription since a single root node is expected and the code generator fails because of that
🦋 Changeset detectedLatest commit: 522de24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Sojaner Can you please add a test for this? |
|
Done @n1ru4l! :) |
n1ru4l
approved these changes
Mar 4, 2024
|
@Sojaner can you please take care of the failing CI? |
|
@n1ru4l can you run the checks again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
__typenameshould not be added to the root node of a subscription when usingaddTypenameSelectionDocumentTransformwithdocumentTransformssince a single root node is expected and the code generator fails because of that (refer to the specification).Related # (issue)
#9888
Type of change
Sandbox:
Issue Sandbox
How Has This Been Tested?
The fix is also included in the issue sandbox. The code can be run in 3 setups for testing:
yarn generatewhich doesn't use the document transformer and works fineyarn generate --add-typenameswhich uses the current faulty document transformer and failsyarn generate --add-fixed-typenameswhich uses my fixed version of the document transformer and works fineTest Environment:
@graphql-codegen/client-preset: 4.2.4Checklist: