Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type fragments as well as queries #30

Closed
vigie opened this issue Jul 30, 2020 · 2 comments
Closed

Type fragments as well as queries #30

vigie opened this issue Jul 30, 2020 · 2 comments
Labels
codegen-plugin Related to `@graphql-codegen/typed-document-node` plugin enhancement New feature or request

Comments

@vigie
Copy link

vigie commented Jul 30, 2020

After running codegen I see that the Queries are now typed with TypedDocumentNode, but the fragments are left as DocumentNode.

It would be great to also type fragments with TypedDocumentNode so that we can get strong typing support when using things like readFragment.
@dotansimha dotansimha added the enhancement New feature or request label Aug 2, 2020
@dotansimha dotansimha mentioned this issue Aug 2, 2020
Merged
@dotansimha
Copy link
Owner

dotansimha commented Aug 2, 2020 •
edited

Fixed in: dotansimha/graphql-code-generator#4462 and dotansimha/graphql-code-generator#4472
Will be available with the next release of codegen :)

@dotansimha dotansimha added the codegen-plugin Related to `@graphql-codegen/typed-document-node` plugin label Aug 2, 2020
@dotansimha dotansimha mentioned this issue Aug 2, 2020
Merged
@dotansimha
Copy link
Owner

Fixed in codegen plugin v1.17.7 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen-plugin Related to `@graphql-codegen/typed-document-node` plugin enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dotansimha @vigie