fix: do not import the unused DocumentNode for typed-document-node #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thank you @mjbcopland ! |
This was referenced Aug 2, 2020
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new(ish?) typed-document-node plugin includes an unused import of the default DocumentNode from ClientSideBaseVisitor. One issue with this is it triggers ESLint's no-unused-vars rule.
This PR moves the custom DocumentNode import to the base class with added customisability similar to the
gqlimport (e.g. it should now be possible to use graphql-typed should you wish) and removes the unused import.