Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency graphql to v15.6.0 #53

Merged
merged 1 commit into from
Sep 21, 2021
Merged

chore(deps): update dependency graphql to v15.6.0 #53

merged 1 commit into from
Sep 21, 2021

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Dec 3, 2020 •
edited

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
graphql 15.3.0 -> 15.6.0 age adoption passing confidence

Release Notes

graphql/graphql-js

v15.6.0

Compare Source

v15.6.0 (2021-09-20)

New Feature 🚀
Committers: 1

v15.5.3

Compare Source

v15.5.3 (2021-09-06)
Bug Fix 🐞
Committers: 2

v15.5.2

Compare Source

v15.5.2 (2021-08-30)
Bug Fix 🐞
Committers: 1

v15.5.1

Compare Source

v15.5.1 (2021-06-20)
Bug Fix 🐞
Internal 🏠
Committers: 2

v15.5.0

Compare Source

v15.5.0 (2021-01-26)
Bug Fix 🐞
Docs 📝
Polish 💅
7 PRs were merged
##### Internal 🏠
7 PRs were merged
##### Dependency 📦
5 PRs were merged
##### Committers: 3 * Ivan Goncharov([@​IvanGoncharov](https://togithub.com/IvanGoncharov)) * Rob Richard([@​robrichard](https://togithub.com/robrichard)) * Saihajpreet Singh([@​saihaj](https://togithub.com/saihaj))

v15.4.0

Compare Source

v15.4.0 (2020-10-26)

New Feature 🚀
Bug Fix 🐞
Docs 📝
4 PRs were merged
##### Polish 💅
40 PRs were merged
##### Internal 🏠
13 PRs were merged
##### Dependency 📦
17 PRs were merged
##### Committers: 10 * Adithya Krishna([@​adithyaakrishna](https://togithub.com/adithyaakrishna)) * null([@​dionisnote](https://togithub.com/dionisnote)) * Dobes Vandermeer([@​dobesv](https://togithub.com/dobesv)) * Emil Sandstø([@​Tapped](https://togithub.com/Tapped)) * Forbes Lindesay([@​ForbesLindesay](https://togithub.com/ForbesLindesay)) * Ivan Goncharov([@​IvanGoncharov](https://togithub.com/IvanGoncharov)) * Mats Byrkjeland([@​draperunner](https://togithub.com/draperunner)) * Matt Mahoney([@​mjmahone](https://togithub.com/mjmahone)) * Naman Kumar([@​hereisnaman](https://togithub.com/hereisnaman)) * Taewan Go([@​solidw](https://togithub.com/solidw))

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot changed the title chore(deps): update dependency graphql to v15.4.0 Update dependency graphql to v15.4.0 Jan 24, 2021
@renovate renovate bot changed the title Update dependency graphql to v15.4.0 Update dependency graphql to v15.5.0 Jan 30, 2021
@renovate renovate bot changed the title Update dependency graphql to v15.5.0 Update dependency graphql to v15.5.1 Jun 20, 2021
@kettanaito
Copy link

Can we please get this merged?

The @graphql-typed-document-node/core@3.1.0 and its TypedDocumentNode is incompatible with the DocumentNode from graphql@15.5.x. There seems to be an interface change between graphql versions 15.0 and 15.5 in the Location interface in DocumentNode['loc']:

// 15.0
export class Location {
  /**
   * The character offset at which this Node begins.
   */
  readonly start: number;

  /**
   * The character offset at which this Node ends.
   */
  readonly end: number;

  /**
   * The Token at which this Node begins.
   */
  readonly startToken: Token;

  /**
   * The Token at which this Node ends.
   */
  readonly endToken: Token;

  /**
   * The Source document the AST represents.
   */
  readonly source: Source;

  constructor(startToken: Token, endToken: Token, source: Source);
}
// 15.5
export class Location {
  /**
   * The character offset at which this Node begins.
   */
  readonly start: number;

  /**
   * The character offset at which this Node ends.
   */
  readonly end: number;

  /**
   * The Token at which this Node begins.
   */
  readonly startToken: Token;

  /**
   * The Token at which this Node ends.
   */
  readonly endToken: Token;

  /**
   * The Source document the AST represents.
   */
  readonly source: Source;

  constructor(startToken: Token, endToken: Token, source: Source);

  // Notice this "toJSON" method being added.
  toJSON(): { start: number; end: number };
}

This type of incompatibility makes typed nodes not assignable to the DocumentNode interface, which they effectively extend.

Use case

I have a generic function that accepts DocumentNode and I wish to pass a TypedDocumetNode as an agument to it:

import { DocumentNode } from 'graphql'

function handler(document: DocumentNode): void

Since TypedDocumentNode extends DocumentNode, it should be a valid argument to the handler function, but it's not due to the DocumentNode interface differences in GraphQL package versions I've pointed out above.

@kettanaito
Copy link

kettanaito commented Jul 18, 2021 •
edited

This being a minor version bump, it shouldn't introduce any breaking changes. @dotansimha, let me know if you need any help in getting this merged. Thank you.

@kettanaito kettanaito mentioned this pull request Jul 18, 2021
Draft
6 tasks
@kettanaito kettanaito mentioned this pull request Jul 29, 2021
Merged
@renovate renovate bot changed the title Update dependency graphql to v15.5.1 chore(deps): update dependency graphql to v15.5.1 Aug 30, 2021
@renovate renovate bot changed the title chore(deps): update dependency graphql to v15.5.1 chore(deps): update dependency graphql to v15.5.2 Aug 30, 2021
@renovate renovate bot changed the title chore(deps): update dependency graphql to v15.5.2 chore(deps): update dependency graphql to v15.5.3 Sep 6, 2021
@renovate renovate bot changed the title chore(deps): update dependency graphql to v15.5.3 chore(deps): update dependency graphql to v15.6.0 Sep 20, 2021
@dotansimha dotansimha merged commit 4c30882 into master Sep 21, 2021
@dotansimha dotansimha deleted the renovate/graphql-15.x branch September 21, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kettanaito @dotansimha @renovate-bot