enhance(cors): call CORS headers factory once (#2238)

dotansimha · Dec 20, 2022 · c152105 · c152105
1 parent b361b8c
commit c152105
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.changeset/long-spiders-pay.md b/.changeset/long-spiders-pay.md
@@ -0,0 +1,5 @@
+---
+'graphql-yoga': patch
+---
+
+Do not call CORS headers factory twice
diff --git a/packages/graphql-yoga/src/plugins/useCORS.ts b/packages/graphql-yoga/src/plugins/useCORS.ts
@@ -144,14 +144,8 @@ export function useCORS<TServerContext extends Record<string, any>>(
   return {
     async onRequest({ request, serverContext, fetchAPI, endResponse }) {
       if (request.method.toUpperCase() === 'OPTIONS') {
-        const headers = await getCORSResponseHeaders<any>(
-          request,
-          corsOptionsFactory,
-          serverContext,
-        )
         const response = new fetchAPI.Response(null, {
           status: 204,
-          headers,
         })
         endResponse(response)
       }