Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context creation error doesn't propagate to plugins #2557

Closed
andyrichardson opened this issue Mar 10, 2023 · 1 comment
Closed

Context creation error doesn't propagate to plugins #2557

andyrichardson opened this issue Mar 10, 2023 · 1 comment

Comments

@andyrichardson
Copy link

Describe the bug

Hi there, thanks for the awesome work!

I'm using this package along with @envelop/sentry. For the most part, it works as expected but when a GraphQL error is thrown during context creation, the error doesn't propagate to envelop plugins.

Your Example Website or App

https://codesandbox.io/s/practical-tree-ed3g9u?file=/src/main.ts

Steps to Reproduce the Bug or Issue

  1. Execute a query
  2. Note the output of REQUEST DETECTED in the console
  3. Change the condition in the context creation function to true
  4. Execute a query

Expected behavior

Expected

REQUEST DETECTED or REQUEST DETECTED (ERROR) is printed to the console

Actual

Errors during context creation are not printed to the console.

i.e. - plugins are not aware of context creation or failure at that time

Screenshots or Videos

No response

Platform

Codesandbox

Additional context

No response

@andyrichardson
Copy link
Author

My bad - I've narrowed this down to the Sentry plugin itself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant