New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upgrade the-guild-docs version #1178
Changes from all commits
51abce3
e506cc4
dfb798b
e2d8df4
aaad96f
0f4ccfb
56e2a86
a375ec9
0007499
2230e95
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -24,18 +24,18 @@ | |||||||||
"author": "Laurin Quast <laurinquast@googlemail.com>", | ||||||||||
"license": "MIT", | ||||||||||
"devDependencies": { | ||||||||||
"@types/react": "18.0.4", | ||||||||||
"@types/react": "17.0.39", | ||||||||||
"@vitejs/plugin-react-refresh": "1.3.6", | ||||||||||
"vite": "2.9.8" | ||||||||||
}, | ||||||||||
"dependencies": { | ||||||||||
"@graphql-tools/url-loader": "^7.9.10", | ||||||||||
"copy-to-clipboard": "^3.3.1", | ||||||||||
"graphiql": "^1.8.4", | ||||||||||
"graphiql": "1.8.4", | ||||||||||
"graphiql-explorer": "^0.9.0", | ||||||||||
"graphql": "^16.3.0", | ||||||||||
"react": "^18.0.0", | ||||||||||
"react-dom": "^18.0.0", | ||||||||||
"react": "17.0.2", | ||||||||||
"react-dom": "17.0.2", | ||||||||||
Comment on lines
+37
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We create a static bundle before releasing this. For consistency and making sure we know the bundled version, I think it is better to go with pinned versions. |
||||||||||
"use-url-search-params": "^2.5.1", | ||||||||||
"json-bigint-patch": "^0.0.8" | ||||||||||
} | ||||||||||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
module.exports = { | ||
i18n: { | ||
defaultLocale: 'en', | ||
locales: ['en'], | ||
}, | ||
exports.i18n = { | ||
defaultLocale: 'en', | ||
locales: ['en'], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why provide it in root package.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I don't want 900000 different versions of react installed by those packages deep in the tree that fuck up declaring loose enough dependency ranges and cause multiple instances of react runtime issues.