Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: defer/stream plugin #1997

Merged
merged 8 commits into from Nov 2, 2022
Merged

feat: defer/stream plugin #1997

merged 8 commits into from Nov 2, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Nov 2, 2022

introduce a new plugin to enable defer/stream in Yoga. Although executor supports defer/stream out of the box it can have many breaking changes so we are using the plugin as a way to conditional expose the functionally of incremental delivery for users. This will act as an opt-in way for users to start using incremental delivery

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

🦋 Changeset detected

Latest commit: 57f8cb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
graphql-yoga Patch
@graphql-yoga/plugin-defer-stream Patch
@graphql-yoga/common Patch
@graphql-yoga/node Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 3.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 3.0.0-alpha-20221102190102-4116dba1 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 155228      ✗ 0    
     data_received..................: 23 MB   771 kB/s
     data_sent......................: 8.9 MB  298 kB/s
     http_req_blocked...............: avg=1.36µs   min=800ns   med=1.1µs   max=1.9ms   p(90)=1.7µs   p(95)=2.1µs   
     http_req_connecting............: avg=22ns     min=0s      med=0s      max=1.71ms  p(90)=0s      p(95)=0s      
   ✓ http_req_duration..............: avg=300.89µs min=202.1µs med=271.7µs max=19.99ms p(90)=332.8µs p(95)=360.34µs
       { expected_response:true }...: avg=300.89µs min=202.1µs med=271.7µs max=19.99ms p(90)=332.8µs p(95)=360.34µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 77614
     http_req_receiving.............: avg=20.83µs  min=11.4µs  med=19µs    max=5.28ms  p(90)=26.6µs  p(95)=29.2µs  
     http_req_sending...............: avg=9.18µs   min=4.3µs   med=7.2µs   max=3.7ms   p(90)=11.8µs  p(95)=12.6µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=270.87µs min=179.6µs med=243.7µs max=19.75ms p(90)=299.3µs p(95)=324.5µs 
     http_reqs......................: 77614   2587.001811/s
     iteration_duration.............: avg=379.89µs min=257.4µs med=348.8µs max=20.72ms p(90)=423.2µs p(95)=453.6µs 
     iterations.....................: 77614   2587.001811/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://b0289cdf.graphql-yoga.pages.dev

@saihaj saihaj requested a review from ardatan November 2, 2022 17:59
@ardatan ardatan merged commit 8773a27 into v3 Nov 2, 2022
@ardatan ardatan deleted the saihaj/defer-stream-plugin branch November 2, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants