Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle errors thrown in onRequest correctly #2257

Merged
merged 1 commit into from Dec 30, 2022
Merged

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Dec 30, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2022

🦋 Changeset detected

Latest commit: f99833f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
graphql-yoga Patch
@graphql-yoga/common Patch
@graphql-yoga/node Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.1.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.1.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
graphql-yoga 3.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 1.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 0.1.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 1.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.2.1-alpha-20221230115952-b75b6e14 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 162290      ✗ 0    
     data_received..................: 23 MB   760 kB/s
     data_sent......................: 9.3 MB  311 kB/s
     http_req_blocked...............: avg=1.29µs   min=800ns   med=1.1µs   max=1.59ms  p(90)=1.6µs    p(95)=1.9µs   
     http_req_connecting............: avg=17ns     min=0s      med=0s      max=1.41ms  p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=290.6µs  min=203.8µs med=261.6µs max=17.22ms p(90)=334.96µs p(95)=365.28µs
       { expected_response:true }...: avg=290.6µs  min=203.8µs med=261.6µs max=17.22ms p(90)=334.96µs p(95)=365.28µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 81145
     http_req_receiving.............: avg=19.4µs   min=11.7µs  med=16µs    max=6.89ms  p(90)=26µs     p(95)=28.29µs 
     http_req_sending...............: avg=7.02µs   min=4.1µs   med=5.2µs   max=4.36ms  p(90)=9.19µs   p(95)=10.1µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=264.17µs min=185.8µs med=239.7µs max=16.82ms p(90)=300.7µs  p(95)=329.5µs 
     http_reqs......................: 81145   2704.687343/s
     iteration_duration.............: avg=363.22µs min=264.1µs med=327.1µs max=19.44ms p(90)=420.7µs  p(95)=451.5µs 
     iterations.....................: 81145   2704.687343/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

🚀 Website Preview

The latest changes to the website are available as preview in: https://d93843c0.graphql-yoga.pages.dev

@ardatan ardatan merged commit 5528d31 into main Dec 30, 2022
@ardatan ardatan deleted the fix-onrequest-error branch December 30, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants