Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export the mask error function + gateway notes #2364

Merged
merged 4 commits into from Jan 31, 2023

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Jan 31, 2023

See #2363

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2023

🦋 Changeset detected

Latest commit: 191e5e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
graphql-yoga Minor
@graphql-yoga/common Patch
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@n1ru4l n1ru4l changed the title feat: export the format error function [draft] feat: export the format error function Jan 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 175656      ✗ 0    
     data_received..................: 25 MB   823 kB/s
     data_sent......................: 10 MB   337 kB/s
     http_req_blocked...............: avg=1.14µs   min=799ns    med=1µs      max=256.69µs p(90)=1.4µs    p(95)=1.6µs   
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=100.79µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=272.65µs min=203.39µs med=249.79µs max=23.06ms  p(90)=285.79µs p(95)=352.59µs
       { expected_response:true }...: avg=272.65µs min=203.39µs med=249.79µs max=23.06ms  p(90)=285.79µs p(95)=352.59µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 87828
     http_req_receiving.............: avg=17.34µs  min=10.6µs   med=15.4µs   max=5.32ms   p(90)=20.79µs  p(95)=23.3µs  
     http_req_sending...............: avg=5.61µs   min=3.9µs    med=4.59µs   max=3.58ms   p(90)=6.1µs    p(95)=7.19µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=249.69µs min=184.29µs med=229.39µs max=22.65ms  p(90)=259.19µs p(95)=312.49µs
     http_reqs......................: 87828   2927.369657/s
     iteration_duration.............: avg=336.77µs min=251.49µs med=308.29µs max=23.28ms  p(90)=358.19µs p(95)=437.69µs
     iterations.....................: 87828   2927.369657/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.4.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.4.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
graphql-yoga 3.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-csrf-prevention 1.1.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 1.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 0.4.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-graphql-sse 1.1.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 1.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.5.0-alpha-20230131141722-c506efa8 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

🚀 Website Preview

The latest changes to the website are available as preview in: https://b3f8effb.graphql-yoga.pages.dev

@n1ru4l n1ru4l changed the title [draft] feat: export the format error function feat: export the format error function + gateway notes Jan 31, 2023
@n1ru4l n1ru4l force-pushed the feat-export-default-format-error branch from 8997cda to 527725f Compare January 31, 2023 14:03
@n1ru4l n1ru4l changed the title feat: export the format error function + gateway notes feat: export the mask error function + gateway notes Jan 31, 2023
@@ -219,7 +219,7 @@ export class YogaServer<
}
}

const logger = options?.logging != null ? options.logging : true
const logger = options?.logging == null ? true : options.logging
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf i did not change this code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint ?

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
@n1ru4l n1ru4l merged commit 03597a5 into main Jan 31, 2023
@n1ru4l n1ru4l deleted the feat-export-default-format-error branch January 31, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants