Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL SSE Distinct Connections support #2445

Merged
merged 9 commits into from
Mar 21, 2023
Merged

GraphQL SSE Distinct Connections support #2445

merged 9 commits into from
Mar 21, 2023

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Feb 16, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2023

🦋 Changeset detected

Latest commit: a12ef36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
graphql-yoga Minor
@graphql-yoga/common Patch
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.7.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.7.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
graphql-yoga 3.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-csrf-prevention 1.4.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 1.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 0.7.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-graphql-sse 1.4.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 1.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.8.0-rc-20230321132710-a12ef366 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 264392      ✗ 0     
     data_received................................: 1.1 GB  9.0 MB/s
     data_sent....................................: 53 MB   445 kB/s
     http_req_blocked.............................: avg=2.02µs   min=1µs     med=1.6µs   max=9.67ms  p(90)=2.29µs   p(95)=2.5µs   
     http_req_connecting..........................: avg=6ns      min=0s      med=0s      max=537.1µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=610.84µs min=289.8µs med=496.3µs max=34.73ms p(90)=889.4µs  p(95)=937.2µs 
       { expected_response:true }.................: avg=610.84µs min=289.8µs med=496.3µs max=34.73ms p(90)=889.4µs  p(95)=937.2µs 
     ✓ { mode:graphql-jit }.......................: avg=465.4µs  min=289.8µs med=406.1µs max=25.94ms p(90)=488.07µs p(95)=539.4µs 
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=950.94µs min=617.9µs med=882.4µs max=34.73ms p(90)=973.03µs p(95)=1.11ms  
     ✓ { mode:graphql-response-cache }............: avg=520.87µs min=306.6µs med=470.3µs max=14.4ms  p(90)=533.1µs  p(95)=566.7µs 
     ✓ { mode:graphql }...........................: avg=635.21µs min=439.8µs med=547.6µs max=24.82ms p(90)=652.4µs  p(95)=776.28µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 132196
     http_req_receiving...........................: avg=35.81µs  min=16.5µs  med=30.5µs  max=11.18ms p(90)=44.8µs   p(95)=49.3µs  
     http_req_sending.............................: avg=16.58µs  min=5.8µs   med=10.1µs  max=4.96ms  p(90)=16.5µs   p(95)=18.59µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=558.45µs min=262µs   med=449.3µs max=34.66ms p(90)=845.4µs  p(95)=883.7µs 
     http_reqs....................................: 132196  1101.610402/s
     iteration_duration...........................: avg=900.8µs  min=506.9µs med=781.9µs max=35.06ms p(90)=1.17ms   p(95)=1.24ms  
     iterations...................................: 132196  1101.610402/s
     vus..........................................: 1       min=1         max=2   
     vus_max......................................: 2       min=2         max=2   

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

💻 Website Preview

The latest changes are available as preview in: https://fe7b8102.graphql-yoga.pages.dev

@ardatan ardatan force-pushed the graphql-sse-compat branch 2 times, most recently from 096368a to 8741125 Compare March 20, 2023 15:30
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

.changeset/tricky-teachers-sin.md Outdated Show resolved Hide resolved
website/src/pages/docs/features/subscriptions.mdx Outdated Show resolved Hide resolved
website/src/pages/docs/features/subscriptions.mdx Outdated Show resolved Hide resolved
ardatan and others added 3 commits March 21, 2023 09:21
Co-authored-by: Denis Badurina <badurinadenis@gmail.com>
Co-authored-by: Denis Badurina <badurinadenis@gmail.com>
Co-authored-by: Denis Badurina <badurinadenis@gmail.com>
@ardatan ardatan merged commit 09d23a4 into main Mar 21, 2023
@ardatan ardatan deleted the graphql-sse-compat branch March 21, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants