Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Drop unused graphiql options defaultVariableEditorOpen and headerEditorEnabled #2776

Merged
merged 5 commits into from May 24, 2023

Conversation

enisdenjo
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: 33df2a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
graphql-yoga Major
@graphql-yoga/common Patch
@graphql-yoga/nestjs Major
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
functions Patch
graphql-yoga-cloud-run-guide Patch
hackernews Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

💻 Website Preview

The latest changes are available as preview in: https://544d158f.graphql-yoga.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 309162      ✗ 0     
     data_received................................: 1.3 GB  11 MB/s
     data_sent....................................: 62 MB   520 kB/s
     http_req_blocked.............................: avg=1.71µs   min=1µs      med=1.5µs    max=968.92µs p(90)=2.2µs    p(95)=2.5µs   
     http_req_connecting..........................: avg=9ns      min=0s       med=0s       max=479.81µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=515.54µs min=273.5µs  med=415.1µs  max=32.12ms  p(90)=754.21µs p(95)=786.61µs
       { expected_response:true }.................: avg=515.54µs min=273.5µs  med=415.1µs  max=32.12ms  p(90)=754.21µs p(95)=786.61µs
     ✓ { mode:graphql-jit }.......................: avg=387.79µs min=273.5µs  med=343.5µs  max=20.15ms  p(90)=407.01µs p(95)=437.81µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=819.31µs min=681.51µs med=751.11µs max=31.41ms  p(90)=816.41µs p(95)=899.2µs 
     ✓ { mode:graphql-response-cache }............: avg=434.44µs min=309.8µs  med=394.2µs  max=17.37ms  p(90)=441.71µs p(95)=461.11µs
     ✓ { mode:graphql }...........................: avg=540.94µs min=395µs    med=465.11µs max=32.12ms  p(90)=548.47µs p(95)=647.71µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 154581
     http_req_receiving...........................: avg=31.89µs  min=17.8µs   med=27.9µs   max=11.85ms  p(90)=40µs     p(95)=44.2µs  
     http_req_sending.............................: avg=14.2µs   min=6.3µs    med=8.6µs    max=7.76ms   p(90)=13.89µs  p(95)=15.8µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=469.44µs min=244.5µs  med=372.4µs  max=32.04ms  p(90)=715.61µs p(95)=741.11µs
     http_reqs....................................: 154581  1288.154236/s
     iteration_duration...........................: avg=770.22µs min=482.81µs med=667.11µs max=32.43ms  p(90)=1ms      p(95)=1.04ms  
     iterations...................................: 154581  1288.154236/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
graphql-yoga-cloud-run-guide 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/apollo-link 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/common 4.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 3.0.13-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
graphql-yoga 4.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs-federation 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/node 4.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-csrf-prevention 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 1.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-graphql-sse 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 2.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 4.0.0-rc-20230524140657-33df2a9e npm ↗︎ unpkg ↗︎

@n1ru4l n1ru4l self-requested a review May 24, 2023 13:15
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enisdenjo can you please investigate the failing CI

@ardatan ardatan merged commit 34ecb4b into main May 24, 2023
33 checks passed
@ardatan ardatan deleted the graphiql-unused branch May 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants