Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically test pull requests #773

Closed
mzdaniel opened this issue Jun 1, 2013 · 9 comments
Closed

Automatically test pull requests #773

mzdaniel opened this issue Jun 1, 2013 · 9 comments

Comments

@mzdaniel
Copy link
Contributor

mzdaniel commented Jun 1, 2013

Testing pull request automatically will have a measurable impact on the code base quality.

@ghost ghost assigned mzdaniel Jun 1, 2013
@shykes
Copy link
Contributor

shykes commented Jun 1, 2013

... as well as on the maintainer's ability to get some sleep :)

On Fri, May 31, 2013 at 5:40 PM, Daniel Mizyrycki
notifications@github.comwrote:

Testing pull request automatically will have a measurable impact on the
code base quality.


Reply to this email directly or view it on GitHubhttps://github.com//issues/773
.

@vieux
Copy link
Contributor

vieux commented Jun 4, 2013

👍 would be awesome, specially to test against, go1.0.3, I mainly us go1.1 and it takes time to test on go1.0.3

@mzdaniel
Copy link
Contributor Author

mzdaniel commented Jun 7, 2013

@vieux: we are trying to deprecate go1.0.3 soon :)

@shykes
Copy link
Contributor

shykes commented Aug 13, 2013

This is implemented.

@shykes shykes closed this as completed Aug 13, 2013
@titanous
Copy link
Contributor

@shykes I don't see commit statuses on pull requests, is there a CI instance somewhere that doesn't update GitHub?

@creack
Copy link
Contributor

creack commented Aug 14, 2013

/cc @mzdaniel

@mzdaniel
Copy link
Contributor Author

@titanous: We'd like to stabilize the testbed before sending the notifications. So far the results are encouraging
(http://docker-ci.dotcloud.com/waterfall) :)

It seems sensitive we properly address at least #1548, #1431, and #1572 first

@mzdaniel mzdaniel reopened this Aug 20, 2013
@mzdaniel
Copy link
Contributor Author

@shykes: Do we want to create a new issue for commit statuses and close this one now that PR #1603 is in place?

@shykes
Copy link
Contributor

shykes commented Aug 21, 2013

Yes please.

On Tue, Aug 20, 2013 at 5:30 PM, Daniel Mizyrycki
notifications@github.comwrote:

@shykes https://github.com/shykes: Do we want to create a new issue for
commit statuses and close this one now that PR #1603https://github.com/dotcloud/docker/issues/1603is in place?


Reply to this email directly or view it on GitHubhttps://github.com//issues/773#issuecomment-22988068
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants