Dockerfile fix #135
Merged
Dockerfile fix #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2014 14:27
- switch to Ubuntu 14.04 LTS - cleanup dependencies installation - actually install current directory Hipache instead of npm registry version, and install it --production - stop monkeying around with config files - add NODE_ENV
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have this in before we release 0.3, in order to get out of the wood with #133
Pretty much, this is about building the docker image from the current directory, instead of fetching the latest from npm.
The rest comes from the benefits of Ubuntu 14.04 (simplifies dependencies installation).