Memoize default run scroll

dotcore64 · May 20, 2020 · dea39d4 · dea39d4
1 parent 0349740
commit dea39d4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -73,6 +73,7 @@
     "react": ">=16.8.0"
   },
   "dependencies": {
+    "memoize-one": "^5.1.1",
     "tiny-invariant": "^1.1.0"
   }
 }
diff --git a/src/index.js b/src/index.js
@@ -2,14 +2,17 @@ import {
   useEffect, useLayoutEffect, useRef, useCallback,
 } from 'react';
 import invariant from 'tiny-invariant';
+import memoize from 'memoize-one';
 import { maxScrollTop } from './util';
 
+// eslint-disable-next-line no-param-reassign
+const defaultRunScroll = memoize((domRef) => (offset) => { domRef.current.scrollTop = offset; });
 const useIsomorphicLayoutEffect = typeof window !== 'undefined' ? useLayoutEffect : useEffect;
 
 export default (domRef, {
   initialScroll = null,
   inaccuracy = 0,
-  runScroll = (offset) => { domRef.current.scrollTop = offset; }, // eslint-disable-line no-param-reassign
+  runScroll = defaultRunScroll(domRef),
 } = {}) => {
   const wasScrolled = useRef(null);