Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s-views-global): Windows node support #103

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jkroepke
Copy link
Contributor

Pull Request

Required Fields

🔎 What kind of change is it?

  • feat

🎯 What has been changed and why do we need it?

  • Added queries for windows nodes

Optional Fields

✔️ Which issue(s) this PR fixes?

💬 Additional information?

  • Let me know, if you need access to an hybrid cluster

@jkroepke jkroepke requested a review from dotdc as a code owner March 17, 2024 12:36
Copy link
Owner

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jkroepke ,

Just did a static review, still need to test this on my side.
Here's already a few questions and remarks.

Also, you updated k8s-views-global.json, but the PR and commit message are "feat(global): Windows node support". We can change that later, but just to make sure you wanted to start with k8s-views-global.json.

dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
"interval": "",
"legendFormat": "Real",
"legendFormat": "Real Linux",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have Real Linux and Real Windows at the same time in graphs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a transformations which merge both Real queries together.

Otherwise, the prometheus query for both windows and linux is quite complex and hard to understand. I choice to use dedicated queries for windows and linux to keep the it more simple for other users. (See line 201+)

dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
dashboards/k8s-views-global.json Show resolved Hide resolved
dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
@jkroepke jkroepke changed the title feat(global): Windows node support feat(k8s-views-global): Windows node support Mar 19, 2024
Copy link
Owner

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CPU Utilization by namespace panel is not working anymore because of the added transformations, can we drop them ?
They don't seems to work anyway (at least on my side)

@jkroepke
Copy link
Contributor Author

the CPU Utilization by namespace panel is not working anymore because of the added transformations, can we drop them ? They don't seems to work anyway (at least on my side)

Yeah, we can drop it. On my site, there are disabled anyways. Sounds strange that they making trouble on your side.

@jkroepke jkroepke requested a review from dotdc March 26, 2024 15:30
@dotdc dotdc merged commit b1e2f0b into dotdc:master Mar 27, 2024
1 check passed
@jkroepke jkroepke deleted the windows/global branch March 27, 2024 15:52
@dotdc
Copy link
Owner

dotdc commented Apr 25, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants