Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default resolution from 30s to 1m #51

Closed
wants to merge 1 commit into from

Conversation

uhthomas
Copy link
Contributor

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • The default resolution of 30s is too low for some Prometheus metrics servers and will result in no data returned for the query. An increase to 1m should fix the issue.

Optional Fields

✔️ Which issue(s) this PR fixes?

💬 Additional information?

  • ...

The default resolution of 30s is too low for some Prometheus metrics servers
and will result in no data returned for the query. An increase to 1m should fix
the issue.

Fixes dotdc#50
@uhthomas uhthomas requested a review from dotdc as a code owner May 26, 2023 20:18
@dotdc
Copy link
Owner

dotdc commented May 29, 2023

I would rather delete the variable completely like mentioned in #50.
Will do the bulk edit tomorrow if that's fine for you.

@dotdc
Copy link
Owner

dotdc commented Jun 1, 2023

Closing as another workaround has been found in #50

@dotdc dotdc closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] default resolution is too low
2 participants