Re-Import Global, Namespace and Nodes

[jkroepke]

Pull Request

Required Fields

🔎 What kind of change is it?

• chore

🎯 What has been changed and why do we need it?

• Just an import and export of the dashboards json via export function.

Optional Fields

✔️ Which issue(s) this PR fixes?

• Fixes Question: How I should export dashboard json #97

💬 Additional information?

• Reduces unnecessary diffs in a future PR

[dotdc]

I didn't comment on each occurrence, but here are a few things that need to be changed.
Also have a few questions, because some changes seems like you manually edited them.

Maybe you can do them one by one and I make a detailed review each time?

[jkroepke]

@dotdc did you had a chance for an additional review?

[dotdc]

Hi @jkroepke,
Just had a look and there are still a few things to change, but I don't see any queries with Windows support.
Maybe it would be easier to make a dashboard, then review the dashboard api details on review?
It won't be a lot, and you already know how to fix most of it.
Let me know.

[jkroepke]

but I don't see any queries with Windows support.

This is correct. This PR should not contain any functional changes.

While I export the JSON dashboard with the windows changes first time, I had so many changes not related to Windows.

Base on that I decide to setup a PR that contains only changes from Grafana, if I do a import and export of the JSON again.

Windows related changed will be introduce in a follow PR

[dotdc]

but I don't see any queries with Windows support.

This is correct. This PR should not contain any functional changes.

While I export the JSON dashboard with the windows changes first time, I had so many changes not related to Windows.

Base on that I decide to setup a PR that contains only changes from Grafana, if I do a import and export of the JSON again.

Windows related changed will be introduce in a follow PR

Sure, just made the review again.
All the rest should be good.

When you'll make the real PR, I'll test the dashboards on my side, and we can fix issues (if any).

[dotdc]

@jkroepke
Also, this is just a test, right?
I don't think we'll be merging this without any functional changes.

[jkroepke]

Changes applied as recommend.

[dotdc]

@jkroepke
Do you want to merge this? Or was it just a test for the export?

[jkroepke]

Yes, please merge, I will setup a second one.

[dotdc]

@jkroepke
Done, also pushed a commit with a version bump for the namespaces dashboard

[dotdc]

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀