-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shows files that were linted #311
Conversation
I think the error is a bug from cargo itself? |
@Anthuang Thank you for your contribution! 🔥
I think not 🤔
|
I made the mistake of not scrolling up haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anthuang Thank you for your contribution! 🔥
I have left some comments. Please look at them 👀
Thanks for the review!! |
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 96.98% 96.69% -0.30%
==========================================
Files 32 33 +1
Lines 2292 2333 +41
==========================================
+ Hits 2223 2256 +33
- Misses 69 77 +8
Continue to review full report at Codecov.
|
I messed up the git history a bit when rebasing, hopefully this fixes it |
@Anthuang Please fix conflicts. |
Done! |
@Anthuang Thank you! I'm going to merge this PR after v2.2.1 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 👍
To be honest, this is not exactly what I imagined after #268 🙁
It seems to me that it was about interactive mode.
When we see the progress of checking files on the fly (many CLI utilities do just that)
Perhaps the dotenv-linter
works very quickly and even with a large number of files it is not necessary, but in this case, it generally does not make much sense, except for displaying the files that have been checked(which is also important) 🤔
What do you say about it @Anthuang @dotenv-linter/core @gillespiecd ?
Either way, moving some of the output logic into a separate module and output of checked files is a great idea! 🚀
You are absolutely right. This is just the first iteration.
Right now |
I completely agree with the division of the task into iterations! 👍
Then it might be more correct at the moment to write |
@DDtKey Maybe you would like to implement on-the-fly output? 😉 |
Why not, I'll gladly take it when we merge to master 🙂 |
@Anthuang Please fix linter's warnings. |
@Anthuang Thanks a lot! 🔥 |
Thanks for the reviews! |
This PR adds functionality to show the files that were linted as part of a dotenv-linter run. It does so by introducing a new struct
Warnings
which is basically a wrapper aroundVec<Warning>
to also include information about the paths related to the warnings.This PR also fixes tests as a result of the added functionality, and some refactoring.
Below shows the output from running dotenv-linter with different args:
✔ Checklist:
Closes #268