New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add total problems to output and --quiet argument #242
Conversation
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea to make a separate flag to control additional output 🚀
The only thing I would point out is that this PR adds not only the --quiet
flag, but also the additional output itself 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Fixed 😃 |
@dotenv-linter/core Need your approval again 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This PR originates from #240.
I decided to add an additional flag to be able not to display verbose information such as "Found n problems".
In #240 PR uses the flag
--no-color
for this, but I think we should add the additional flag--quiet
.✔ Checklist: