Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unordered keys for substitution variables (#382) #401

Merged
merged 5 commits into from Mar 30, 2021
Merged

Allow unordered keys for substitution variables (#382) #401

merged 5 commits into from Mar 30, 2021

Conversation

Ru5ty0ne
Copy link
Contributor

@Ru5ty0ne Ru5ty0ne commented Mar 24, 2021 •
edited

Solves #382

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);

@Ru5ty0ne Ru5ty0ne changed the title Allow unordered keys for substituion variables (#382) Allow unordered keys for substitution variables (#382) Mar 24, 2021
@DDtKey DDtKey linked an issue Mar 24, 2021 that may be closed by this pull request
Allow unordered keys for substituion variables #382
Closed
DDtKey
DDtKey reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 👍
I left some comments, take a look at them pls 🙂

src/checks/unordered_key.rs Outdated Show resolved Hide resolved
src/checks/unordered_key.rs Outdated Show resolved Hide resolved
src/checks/unordered_key.rs Show resolved Hide resolved
@Ru5ty0ne
Copy link
Contributor Author

Should I do something about linter's warning about commits not following Conventional Commits format?

@mgrachev
Copy link
Member

Should I do something about linter's warning about commits not following Conventional Commits format?

Please, rebase your earlier commits.
https://github.com/dotenv-linter/dotenv-linter/pull/401/checks?check_run_id=2211833110

@Ru5ty0ne
Copy link
Contributor Author

Please, rebase your earlier commits.

Done.

@mgrachev mgrachev added this to the v3.1.0 milestone Mar 30, 2021
@mgrachev mgrachev merged commit a387862 into dotenv-linter:master Mar 30, 2021
@mgrachev
Copy link
Member

@Ru5ty0ne Thank you for your help 🔥

🙏 If it’s not difficult for you, please support the project - star on GitHub ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDtKey DDtKey DDtKey left review comments

@mgrachev mgrachev mgrachev approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Allow unordered keys for substituion variables
3 participants
@Ru5ty0ne @mgrachev @DDtKey