Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Open path' does not work on files when using pcmanfm-qt filemanager #55

Closed
ghost opened this issue Jul 20, 2018 · 7 comments
Closed

'Open path' does not work on files when using pcmanfm-qt filemanager #55

ghost opened this issue Jul 20, 2018 · 7 comments

Comments

@ghost
Copy link

ghost commented Jul 20, 2018

Hello!

I don't know whether this is an AngrySearch problem or a pcmanfm-qt problem but, when using AngrySearch's 'open path' function on a file, and when the file manager is set (globally and within AngrySearch) to pcmanfm-qt, then nothing happens. When the item in question is a folder, though, then 'open path' works. When I used nemo or indeed pcmanfm (the non 'qt' version), 'open with' worked for both folders and files.

AngrySearch version: unknown, but fairly recent, and from github.

@ghost
Copy link
Author

ghost commented Jul 22, 2018

When I run angrySearch in the terminal, in says the following, even when angrySearch.conf specifies nemo as the filemanager

autodetected file manager: pcmanfm

I think this is the problem. I do not have pcmanfm installed anymore - but I do have pcmanfm-qt.

@ghost
Copy link
Author

ghost commented Jul 25, 2018

I know how to fix this. I do not know how to file pull requests, so I'll specify the code change here.

One needs to insert, in /usr/share/angrysearch/angrysearch.py, and between line 792 and line 793 - yielding a new line 793 - this:

  'pcmanfm-qt',

@DoTheEvo
Copy link
Owner

will check out

@DoTheEvo
Copy link
Owner

DoTheEvo commented Jul 28, 2018

when using AngrySearch's 'open path' function on a file, and when the file manager is set (globally and within AngrySearch) to pcmanfm-qt, then nothing happens. When the item in question is a folder, though, then 'open path' works.

had a look, the issue was that in the end the program detected pcmanfm-qt but called pcmanfm to open the file

should be fixed now

When I run angrySearch in the terminal, in says the following, even when angrySearch.conf specifies nemo as the filemanager

autodetected file manager: pcmanfm

that is strange and should not happen, there was some issue with config file being named differently(angry_database.conf), so if you just tried not the latest release but just recent commit using "clone or download" green button, you might have get that build and it might kinda ignore your original config.

Otherwise it should never talk about autodetecting when you have something written in the config file in the line file_manager=blabla

@ghost
Copy link
Author

ghost commented Jul 28, 2018

No dice.

More specifically: I just tried the git version, with an angrysearch.conf specifying no file manager, and I had the original problem, viz., angrySearch would not open the file manager. Moreover, angrySearch autodetected the file manager as 'pcmanfm', not 'pcmanfm-qt'. I discover though that I have an angry_database.conf on my system, too (though it does not specify a file manager either); which of the two config file should I keep and use?

Solution - well, it worked for me: ensure that pcmanfm-qt precedes pcmanfm in the 'known_fm' list.

@DoTheEvo
Copy link
Owner

Alright, made that change and tested it, seems to be working.
Delete the angry_database.conf

@ghost
Copy link
Author

ghost commented Jul 28, 2018

Thanks. It must be to do with how your search algorithm works - but I don't know Python (or your code, really).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant