Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic styles can easily be unintentionally overridden #1

Closed
dotherightthing opened this issue Feb 3, 2021 · 2 comments
Closed

Generic styles can easily be unintentionally overridden #1

dotherightthing opened this issue Feb 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@dotherightthing
Copy link
Owner

dotherightthing commented Feb 3, 2021

  1. Plugin A loads wpdtrt-scss version 1
  2. Plugin B loads wpdtrt-scss version 2
  3. Plugin W loads wpdtrt-scss version 1

Version 1's styles are applied because Plugin W was loaded last.

It might be best to load the generic styles in the theme only.

@dotherightthing dotherightthing added the bug Something isn't working label Feb 3, 2021
@dotherightthing
Copy link
Owner Author

See #3

@dotherightthing
Copy link
Owner Author

The front end file leverages the various @extends in the library and is commented as being optional

//
// Styles for the front-end (optional import)
//
// Theme + Plugin usage: @import '../node_modules/wpdtrt-scss/scss/_frontend';
//
// @package     WPDTRT_SCSS
// @since       0.1.0
//

dotherightthing added a commit to dotherightthing/wpdtrt-anchorlinks that referenced this issue Aug 6, 2021
dotherightthing added a commit to dotherightthing/wpdtrt-exif that referenced this issue Aug 6, 2021
dotherightthing added a commit to dotherightthing/wpdtrt-form that referenced this issue Aug 6, 2021
dotherightthing added a commit to dotherightthing/wpdtrt-gallery that referenced this issue Aug 6, 2021
dotherightthing added a commit to dotherightthing/wpdtrt-table that referenced this issue Aug 6, 2021
dotherightthing added a commit to dotherightthing/wpdtrt-tourdates that referenced this issue Aug 6, 2021
dotherightthing added a commit to dotherightthing/wpdtrt-weather that referenced this issue Aug 6, 2021
dotherightthing added a commit to dotherightthing/wpdtrt-conversation that referenced this issue Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant