Fix potential MissingBackpressureException #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case notifications/indications come too quickly to be pushed through the bridge to non-native side there will be emitted a `MissingBackpressureException` from RxJava. To mitigate the problem a buffering backpressure strategy is added which should help in most common situations. Pros: - No notifications will be discarded Cons: - Potential `OutOfMemoryException` in case of prolonged, high speed notifications Technically backpressure strategy should be exposed on the API level but can be introduced at a later moment.
|
Does this issue occurs only on Android? |
mikolak
approved these changes
Jan 22, 2020
|
Also: please create an issue for exposing it in the API. |
AFAIK — Yes
There are no API changes. Or I did not get the point. Could you explain? |
|
I meant this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case notifications/indications come too quickly to be pushed through the bridge to non-native side there will be emitted a
MissingBackpressureExceptionfrom RxJava. To mitigate the problem a buffering backpressure strategy is added which should help in most common situations.Pros:
Cons:
OutOfMemoryExceptionin case of prolonged, high speed notificationsTechnically backpressure strategy should be exposed on the API level but can be introduced at a later moment.