Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 13 error builds #899

Closed
nriccar opened this issue Sep 22, 2021 · 20 comments
Closed

Xcode 13 error builds #899

nriccar opened this issue Sep 22, 2021 · 20 comments
Labels

Comments

@nriccar
Copy link

nriccar commented Sep 22, 2021

Hello,

I noticed my Xcode updated to 13
Screenshot 2021-09-22 at 16 07 46

And right after that I started getting this error at build:

Screenshot 2021-09-22 at 16 08 04
Screenshot 2021-09-22 at 16 08 25
Screenshot 2021-09-22 at 16 08 32
Screenshot 2021-09-22 at 16 08 40
Screenshot 2021-09-22 at 16 08 49

I run pod update

Downloading dependencies
Installing MultiplatformBleAdapter 0.1.7 (was 0.1.6)
Installing react-native-ble-plx 2.0.2 (was 2.0.1)
Generating Pods project
Integrating client project
Pod installation complete! There are 81 dependencies from the Podfile and 71 total pods installed.

But same error

Any guess?

@nriccar nriccar added the bug label Sep 22, 2021
@wildseansy
Copy link

wildseansy commented Sep 22, 2021

Seems like they're working on a fix:
dotintent/MultiPlatformBleAdapter#79
dotintent/MultiPlatformBleAdapter@669e438

but appears it hasn't been released yet

@nriccar
Copy link
Author

nriccar commented Sep 22, 2021

Thanks for the heads up. Ill check that one!

@nriccar nriccar closed this as completed Sep 22, 2021
@nriccar nriccar reopened this Sep 24, 2021
@xanderdeseyn
Copy link

Seeing this as well, any idea when they will release the fix?

@diogoviannaaraujo
Copy link

This has made impossible to develop on iOS 15 since XCode 12 does not accept iOS 15 devices as a development target.

@wildseansy
Copy link

Maybe it wasn't clear, but can be fixed while they prepare release through patch package

dotintent/MultiPlatformBleAdapter#79

This has made impossible to develop on iOS 15 since XCode 12 does not accept iOS 15 devices as a development target.

@LucasHimelfarb
Copy link

Hi @wildseansy sorry to bother you but could you indicate what are the steps to follow to solve the error? Reading and replicating what was said in the thread you shared, I can't solve the problem.

@wildseansy
Copy link

wildseansy commented Sep 28, 2021

  1. Install patch-package - npm i patch-package --save-dev
  2. Add this under patches patches/react-native-ble-plx+2.0.2.patch
diff --git a/node_modules/react-native-ble-plx/react-native-ble-plx.podspec b/node_modules/react-native-ble-plx/react-native-ble-plx.podspec
index def210f..0a92dcc 100644
--- a/node_modules/react-native-ble-plx/react-native-ble-plx.podspec
+++ b/node_modules/react-native-ble-plx/react-native-ble-plx.podspec
@@ -17,5 +17,5 @@ Pod::Spec.new do |s|
   s.compiler_flags = '-DMULTIPLATFORM_BLE_ADAPTER'

   s.dependency 'React'
-  s.dependency 'MultiplatformBleAdapter', '0.1.7'
+  s.dependency 'MultiplatformBleAdapter', '0.1.9'
 end
  1. Add yarn patch-package to your "postinstall" script in your package.json
{
  "scripts": {
    "postinstall": "yarn patch-package",
  }
}
  1. Add this to your Podfile
pod 'MultiplatformBleAdapter', :git => 'https://github.com/below/MultiPlatformBleAdapter', :tag => '0.1.9'

This points to a fork that @below released while we wait

More info in https://www.npmjs.com/package/patch-package, but basically you make whatever changes you need under node_modules then run npx patch-package <package you edited>. This generates a diff which then is expressed whenever you run yarn install. In this case, you just need to upgrade what MultiplatformBleAdapter cocoapod the react-native-ble-plx points to, from 0.1.7 to 0.1.9. 0.1.9 works with XCode 13, 0.1.7 doesn't

Hi @wildseansy sorry to bother you but could you indicate what are the steps to follow to solve the error? Reading and replicating what was said in the thread you shared, I can't solve the problem.

@diogoviannaaraujo
Copy link

diogoviannaaraujo commented Sep 29, 2021

@wildseansy I've been trying doing the patch on postinstall but when running pod install I keep getting this error:

[!] CocoaPods could not find compatible versions for pod "MultiplatformBleAdapter":
  In Podfile:
    react-native-ble-plx (from `../node_modules/react-native-ble-plx`) was resolved to 2.0.2, which depends on
      MultiplatformBleAdapter (= 0.1.9)

None of your spec sources contain a spec satisfying the dependency: `MultiplatformBleAdapter (= 0.1.9)`.

You have either:
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Checking the Cocoapods spec repo I could find the 0.1.9 version available yet.

@wildseansy
Copy link

@diogoviannaaraujo - I forgot step 4. Update your podfile to point to new cocoapod and you'll be good to go

  1. Add this to your Podfile

@diogoviannaaraujo
Copy link

Great, thanks that worked.

@marcoj
Copy link

marcoj commented Sep 30, 2021

And you'll probably need to

pod update
pod repo update
pod install

@LucasHimelfarb
Copy link

adding patch for podspec and also adding as pod bleAdapter is the working solution for now. Thanks for the help

@sofiaschn
Copy link

It looks like the MultiPlatformBleAdapter library has already released version 0.1.9 with the fix. If possible, can we get a new react-native-ble-plx version with these fixes? Thanks!

The way i fixed it, at least until the fixes get to Cocoapods, is by replacing the library's folder (Pods/MultiplatformBleAdapter) with a clone from the 0.1.9 release (make sure the names match). Then, run 'pod install' and it should work for now.

@sofiaschn
Copy link

This issue can be solved by merging the pull request: #900

@scinfu
Copy link

scinfu commented Oct 8, 2021

Any roadmap for this bug?

@marcoj
Copy link

marcoj commented Oct 14, 2021

Any news?

@marcoj
Copy link

marcoj commented Nov 9, 2021

This has been fixed with the 2.0.3 release. You can close this issue.

@LucasHimelfarb
Copy link

LucasHimelfarb commented Dec 2, 2021

2.0.3 dont work for me. I have the same issue again

@mciechanowicz
Copy link
Contributor

Hi everyone! The issue with Xcode 13 was fixed in the 2.0.3 version!

@LucasHimelfarb can you give more details about your Issue?

@mciechanowicz
Copy link
Contributor

At this point, the problem seems to be solved so I close this issue. If anyone still has problems please report a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants