Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #147 #148 #153: dot-session related fixes. #154

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

alexmerlin
Copy link
Member

No description provided.

@alexmerlin alexmerlin self-assigned this Feb 14, 2023
Copy link
Member

@arhimede arhimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in readme.md
instead of
so make sure you modify your local.php, as per the following:

to be:
so make sure you modify your session.global.php, as per the following:

@alexmerlin
Copy link
Member Author

in readme.md instead of so make sure you modify your local.php, as per the following:

to be: so make sure you modify your session.global.php, as per the following:

Short answer:
My point with that sentence is to remind developers to add session_config.cookie_secure = false ONLY to local.php, without adding it to local.php.dist or session.global.php as well because that will disable secure cookies on production.

Long answer:
As discussed today, we want to keep in session.global.php the configuration session_config.cookie_secure set to true - this way developers don't need to remember to enable it on production.
Setting session_config.cookie_secure to false directly in session.global.php and comitting the file to the repo will disable the configuration on production as well.
Tha's why I recommended setting session_config.cookie_secure in local.php and remind developers to not add it to local.php.dist as well (because when developing, we add a config in local.php and then update local.php.dist with the same config).

@arhimede arhimede merged commit e7c4a94 into 4.0 Feb 15, 2023
@arhimede arhimede deleted the issue-147-148-153 branch February 15, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants