Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message and temp NTNU email address block on register page #3008

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

Terbau
Copy link
Contributor

@Terbau Terbau commented Aug 13, 2023

Because NTNU email addresses don't seem to be getting any emails from our domain, we need to temporarily disable the usage of stud.ntnu.no addresses. This could have been done in a better way, but this is the most realistic solution for now considering we are expecting a lot of new users in not too long.

Preview

image

@Terbau Terbau self-assigned this Aug 13, 2023
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #3008 (d5ef521) into main (b6e66d2) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
- Coverage   78.69%   78.65%   -0.05%     
==========================================
  Files         338      338              
  Lines       14926    14923       -3     
==========================================
- Hits        11746    11737       -9     
- Misses       3180     3186       +6     
Files Changed Coverage Δ
apps/authentication/forms.py 44.30% <0.00%> (+1.62%) ⬆️

... and 2 files with indirect coverage changes

@Terbau Terbau merged commit b08be2e into main Aug 14, 2023
8 of 10 checks passed
@Terbau Terbau deleted the add-temp-ntnu-mail-block branch August 14, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants