Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikhorluck
force-pushed
the
feat/marihøne
branch
5 times, most recently
from
f82dc82
to
a4d33e4
Compare
henrikhorluck
force-pushed
the
feat/marihøne
branch
from
a4d33e4
to
b7e4c0e
Compare
henrikhorluck
force-pushed
the
feat/marihøne
branch
2 times, most recently
from
aa392ee
to
38c91d5
Compare
- Remove active field on suspension in favour of expiration_date - Fix "Prikk for" extra text in migration - Make mark duration configurable based on ruleset - Be consistent about what is an active/inactive suspension, the term of an expiring suspension is new, and likely has some text-errors elsewhere - Found a potential bug w/ auto_now vs auto_now_add⚠️ we probably have multiple 🐛's related to this since the later updates every time an object is changed, instead of just at creation time. - Add some actually useful tests - Remove unused fields on events, saving several RTTs / queries - Remove some other dead/unused code - Mostly remove usage of MarkUser, and move expiration_date to Mark instead of MarkUser since we no longer have the rather complex logic when adding a new mark - Probably introduce at least 20 new bugs 🎉
henrikhorluck
force-pushed
the
feat/marihøne
branch
from
38c91d5
to
6c8fd3d
Compare
henrikskog
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marihøner har prikker. 🐞
Rules implemented: https://old.online.ntnu.no/wiki/komiteer/nyeprikkregler/
Tests should be re-calculated to verify that the new values are correct. This also needs more tests covering the example cases from the rules