Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a quick null check for input in the Currency filter and added an associated testcase.
Without this check a null reference exception is thrown whenever the input is null(which is a quite common scenario if we pass in a property of a model) and stopping the render of the entire template.
PS: Tried to create an issue first but couldn't for some reason. hence opened the PR directly. Please let me know if I have to follow a different process for the same. Here is my issue notes:
Dotliquid version 2.1.457
Expected behavior To render null if the input is null for a currency filter
Actual behavior It is throwing a null reference exception if I pass in a null property(which is highly possible)
Steps to reproduce the Problem (you can add files)
{{Customer.Amount | currency:'fr-CA'}}
or
Use DotLiquid syntax with currency filter
{{null | currency:'fr-CA'}}