Feat/audio #52
Merged
Feat/audio #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: afafbe2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samuelOsborne
force-pushed
the
feat/audio
branch
from
0dc98ed
to
0db4366
Compare
size-limit report 📦
|
theashraf
reviewed
Sep 6, 2023
Comment on lines
+189
to
+193
| it('returns the audio', async () => { | ||
| const audio = await getAudio(dotLottieAnimationWithAudio, 'audio_1.mpeg'); | ||
|
|
||
| expect(audio?.length).toBeGreaterThan(0); | ||
| }); |
There was a problem hiding this comment.
Asserting on the length, doesn't guarantee that it return a valid audio, is it possible to check if the actual audio_1.mpeg equal to the extracted audio ?
theashraf
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds audio asset detection and support: