This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Modernization #2107
Merged
Modernization #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hem being added again
- Lots of duplication zomg
- Removed manual port binding code - Disable Seq and logstash if config is null - Disable serilog for now - Remove IIS from some launch profiles - Clean up some logging.
…oesn't crash on startup
16 tasks
|
This is great work, you guys nailed it. I'll review and test it. |
|
@erjain merge when ready |
This was referenced May 30, 2023
|
I think this update means that logs are no longer appearing in Seq. Is this intentional? There still is a Seq container in |
|
Yes it’s intentional. We’re also not done with the clean up. This was just the first big set of changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a joint effort between @davidfowl & myself to modernize and clean up eShop.
There is more to do, but we wanted to merge what we have so far before we continue.
@erjain, we have tested this locally in VS (launch & manually test + automated tests) and via docker compose, but we haven't tested beyond that (Kubernetes, Azure). I don't expect you to review this because the PR is far too large, but if you could run some of your own tests, that would be greatly appreciated.
Addresses #2070