Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Master #348

Closed
wants to merge 23 commits into from
Closed

Master #348

wants to merge 23 commits into from

Conversation

karumanchi1116
Copy link

No description provided.

#USE_LOADTEST=<True/False>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an unnecessary change to commit. nothing was changed.

@@ -1,12 +1,12 @@
# eShopOnContainers

eShopOnContainers is a reference app whose imagined purpose is to serve the mobile workforce of a fictitious company that sells products. The app allow to manage the catalog, view products, manage the basket and the orders.
eShopOnContainers is a reference app whose imagined purpose is to serve the mobile workforce of a fictitious company that sells products. The app would allow a user to manage their catalog, view products, manage the basket/cart and the orders.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

The app would allows the user to manage their catalog, view products, manage the basket/cart and the orders.

@@ -97,7 +97,7 @@ The app has the following screens:

* a auth screen
* a catalog list
* a profile section with a order list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

a profile section with a list of orders

@@ -142,7 +142,7 @@ The application performs the deployment and even boots into the emulator, but st

The error is related with incompatibilities between the host processor and the Hyper-V virtual machine.

In Windows 10, we press the start button and write MMC. Next, click the Hyper-V Manager option:
In Windows 10, we press the start button and write MMC, short for Microsoft Management Console. Next, click the Hyper-V Manager option:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

In Windows 10, we press the start button and write MMC, short for Microsoft Management Console. Next, click the Hyper-V Manager option:

@dnfclas
Copy link

dnfclas commented Dec 14, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ karumanchi1116 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@mvelosop
Copy link
Collaborator

Hi @karumanchi1116, thanks for your contributions, but we don't accept PRs to master, as per https://github.com/dotnet-architecture/eShopOnContainers/blob/master/branch-guide.md.

If you want to submit the PR, please fork the repo in GitHub and create the new branch from the current dev.

Please keep in mind that you must also sign the Contributor License Agreement (CLA) to accept th PR.

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants