Merge pull request #848 from AskBojesen/828_null_in_devicelist_windows

Windows: Fixed null entries in DiscoveredDevices #828
dotnet-bluetooth-le · May 11, 2024 · 18d5e3f · 18d5e3f
2 parents a5f8e6c + 5d152a0
commit 18d5e3f
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/Source/Plugin.BLE/Windows/Adapter.cs b/Source/Plugin.BLE/Windows/Adapter.cs
@@ -266,13 +266,14 @@ private void AdvertisementReceived(BluetoothLEAdvertisementWatcher watcher, Blue
         {
             var deviceId = btAdv.BluetoothAddress.ParseDeviceId();
 
-            if (DiscoveredDevicesRegistry.TryGetValue(deviceId, out var device) && device != null)
+            if (DiscoveredDevicesRegistry.TryGetValue(deviceId, out var device))
             {
+                // This deviceId has been discovered
                 Trace.Message("AdvReceived - Old: {0}", btAdv.ToDetailedString(device.Name));
                 (device as Device)?.Update(btAdv.RawSignalStrengthInDBm, ParseAdvertisementData(btAdv.Advertisement));
-                this.HandleDiscoveredDevice(device);
+                HandleDiscoveredDevice(device);
             }
-            if (device == null)
+            else
             {
                 var bluetoothLeDevice = BluetoothLEDevice.FromBluetoothAddressAsync(btAdv.BluetoothAddress).AsTask().Result;
                 if (bluetoothLeDevice != null) //make sure advertisement bluetooth address actually returns a device
@@ -285,12 +286,7 @@ private void AdvertisementReceived(BluetoothLEAdvertisementWatcher watcher, Blue
                         ParseAdvertisementData(btAdv.Advertisement),
                         btAdv.IsConnectable);
                     Trace.Message("AdvReceived - New: {0}", btAdv.ToDetailedString(device.Name));
-                    _ = DiscoveredDevicesRegistry.TryRemove(deviceId, out _);
-                    this.HandleDiscoveredDevice(device);
-                }
-                else
-                {
-                    DiscoveredDevicesRegistry[deviceId] = null;
+                    HandleDiscoveredDevice(device);
                 }
             }
         }