return error codes to application

[chrimaka]

That's a PR for passing the error codes from the stack to the application. It requires a bit more fine tuning (null checks; casting of CBErrors from iOS). But this would be the general concept. Feedback very welcome.

[janusw]

Thanks for the PR! Unfortunately the build fails with errors like this:

build: Source/Plugin.BLE/Windows/Characteristic.cs#L50
'Characteristic.ReadNativeAsync()': return type must be 'Task<Tuple<byte[], int>>' to match overridden member 'CharacteristicBase<GattCharacteristic>.ReadNativeAsync()'

Please fix! :)

[chrimaka]

@janusw I have a question on the build process. I was able to build the former 2.1.x "out of the box". I also can build the Plugin.BLE.sln without issues, but If I try to build BLE.sln, VS2022 for macOS (17.5.3 (build 15)) already gives me an error during opening error NETSDK1045: Das aktuelle .NET SDK unterstützt .NET Core 6.0 nicht als Ziel. Geben Sie entweder .NET Core 5.0 oder niedriger als Ziel an, oder verwenden Sie eine .NET SDK-Version, die .NET Core 6.0 unterstützt. Für das Projekt kann keine Paketspezifikation erstellt werden.

I should have the relevant SDKs installed:

dotnet --list-sdks
6.0.404 [/usr/local/share/dotnet/sdk]
6.0.405 [/usr/local/share/dotnet/sdk]
6.0.406 [/usr/local/share/dotnet/sdk]
6.0.407 [/usr/local/share/dotnet/sdk]
7.0.101 [/usr/local/share/dotnet/sdk]
7.0.102 [/usr/local/share/dotnet/sdk]
7.0.103 [/usr/local/share/dotnet/sdk]
7.0.200 [/usr/local/share/dotnet/sdk]
7.0.202 [/usr/local/share/dotnet/sdk]

dotnet currently points to 7.0.202 and msbuild is installed with version 16.10.1.60101. As specified in this help article I tried turn on/off using msbuild on mono, but without any success. (I'm building on macOS). Any idea how to overcome this issue?

[janusw]

@janusw I have a question on the build process. I was able to build the former 2.1.x "out of the box". I also can build the Plugin.BLE.sln without issues, but If I try to build BLE.sln, VS2022 for macOS (17.5.3 (build 15)) already gives me an error during opening error NETSDK1045: Das aktuelle .NET SDK unterstützt .NET Core 6.0 nicht als Ziel. Geben Sie entweder .NET Core 5.0 oder niedriger als Ziel an, oder verwenden Sie eine .NET SDK-Version, die .NET Core 6.0 unterstützt. Für das Projekt kann keine Paketspezifikation erstellt werden.

I'm afraid that's some sort of deficiency of VS4Mac. VS on Windows should work AFAIK. Maybe we can find a workaround ...

[janusw]

Overall this looks pretty good to me, but I have some minor comments ...

[janusw]

@janusw I have a question on the build process. I was able to build the former 2.1.x "out of the box". I also can build the Plugin.BLE.sln without issues, but If I try to build BLE.sln, VS2022 for macOS (17.5.3 (build 15)) already gives me an error during opening

This is fixed (or rather worked around) by now via #685. Using BLE.Mac.slnf should work on Mac (however, it only includes the core libraries, but not all the sample clients).

[janusw]

@chrimaka Could you take care of the remaining comments, or should I fix them (so that we can move forward with this)? It would be nice if we could merge it soon.

[chrimaka]

@janusw sorry for the late reply. I was out sick for some time. I'll look into this on Thrusday/Friday + Weekend.

[janusw]

Awesome, thanks for addressing all my comments. This is ok for master by now.