Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all Uses of Frame to Border #2

Open
PureWeen opened this issue Mar 19, 2022 · 3 comments
Open

Change all Uses of Frame to Border #2

PureWeen opened this issue Mar 19, 2022 · 3 comments
Assignees
@jsuarezruiz

Comments

@PureWeen
Copy link
Collaborator

PureWeen commented Mar 19, 2022 •
edited
Loading

Border is the new recommended way of doing things.

I played with converting this a little bit but you might reach out to Javier on the recommended replacements here

  • CornerRadius => Border.Clip
  • BorderColor => Stroke
  • HasShadow => Border.Shadow
@jamesmontemagno
Copy link
Collaborator

Yeah I actually had this in there originally, but couldn't get it working well across all the devices. I'll ping Javier

@jamesmontemagno
Copy link
Collaborator

@jsuarezruiz thouhts on this one?

@jsuarezruiz jsuarezruiz self-assigned this Mar 24, 2022
jamesmontemagno pushed a commit that referenced this issue Nov 18, 2022
@C0HERENCE
Merge pull request #2 from C0HERENCE/patch-2
8b38eef 
Update README.zh-cn.md
@jamesmontemagno
Copy link
Collaborator

I added this in for the details page. Still not sure on the main page yet, will look into it in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuarezruiz jsuarezruiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamesmontemagno @PureWeen @jsuarezruiz