Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear MSBuild related env variables before dotnet restore #233

Merged
merged 2 commits into from Mar 6, 2018
Merged

Clear MSBuild related env variables before dotnet restore #233

merged 2 commits into from Mar 6, 2018

Conversation

seesharper
Copy link
Collaborator

This PR fixes #230. We need to get another release out the door so OmniSharp can reference the new Dotnet.Script.DependencyModel package. 馃憤

@seesharper seesharper requested a review from filipw March 6, 2018 17:59
filipw
filipw approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seesharper
Copy link
Collaborator Author

@filipw All lights are green 馃樃

@filipw filipw merged commit 664f320 into master Mar 6, 2018
@filipw filipw deleted the bug/issue230 branch March 6, 2018 21:00
@filipw
Copy link
Member

filipw commented Mar 6, 2018

thanks!

@seesharper seesharper mentioned this pull request Mar 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intellisense not working for inline dependencies
2 participants
@seesharper @filipw