Issue226 test. #238
Issue226 test. #238
Conversation
|
Is this the test proving failure from #226 ? |
|
Yea, but the test is inaccurate, fixing that now. |
|
Looks like travis-ci Linux build succeeded, I guess then my environment setup is incorrect. |
| #! "netcoreapp2.0" | ||
| #r "nuget: Castle.Core,*" | ||
|
|
||
| Process.Start(new ProcessStartInfo { |
There was a problem hiding this comment.
Is it referencing Castle.Core that causes the error or is it starting the process? And how are they related 😄 ?
There was a problem hiding this comment.
The error happens only when I reference one of "those" nugets, that probably reference ether newer or older System.ComponentModel.Primitives package, that would be my guess.
There was a problem hiding this comment.
I know there were some kind of a bug when you upgrade I think from dotnet 2.0.* to 2.1.* that might be my problem. I already reinstalled it on my machine quite a few times, but I think there was another step that I needed todo, however can't find the article for this -.-.
There was a problem hiding this comment.
Does this mean that it still fails for you on Linux?
There was a problem hiding this comment.
Are you running .Net Core 2.1 Preview?
There was a problem hiding this comment.
me@my-pc ~ $ apt list --installed | grep dotnet*
WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
dotnet-host/xenial,now 2.1.0-preview1-26216-03-1 amd64 [installed,automatic]
dotnet-hostfxr-2.0.5/xenial,now 2.0.5-1 amd64 [installed,automatic]
dotnet-runtime-2.0.5/xenial,now 2.0.5-1 amd64 [installed,automatic]
dotnet-runtime-deps-2.1.0-preview1-26216-03/xenial,now 2.1.0-preview1-26216-03-1 amd64 [installed,automatic]
dotnet-sdk-2.1.4/xenial,now 2.1.4-1 amd64 [installed]
I'm pretty sure I do :)
There was a problem hiding this comment.
I see. The Travis build uses .net Core 2.0 so that is probably why it does not fail there.
We haven't really started to look at .Net Core 2.1 yet, but I guess it would be possible to add that to the build matrix as well. It does not make all that much sense to merge this without seeing it fail. Only then would we know where to fix it 👍
There was a problem hiding this comment.
Hmm, haven't thought that 2.1 might be a problem, I might try downgrading to 2.0 :). It's not a big deal, I made this PR, so it would be easier to see where the problem is, but since there is no problem we can close this PR.
|
@filipw Should we set up a build based on .Net Core 2.1 preview or do we wait until RTM? Guess it does not hurt to be a little prepared for what's coming 😄 |
|
I can try updating travis-ci with net sdk 2.1 preview on this pr to see if it fails :? |
I think we just wait and see if this is a problem when 2.1 ships. If you just update the branch, we'll merge this as a regression test ensuring that we don't hit this in the future |
|
I've reinstalled dotnet and removed fallback packages, tried with dotnet sdk 2.0.3 and 2.1.4 still no luck. |
|
The important thing is that I can run I also can run generated using System;
using System.Diagnostics;
class Program
{
static void Main()
{
Process.Start(new ProcessStartInfo {
Arguments = "--version",
FileName = "dotnet",
RedirectStandardError = true,
RedirectStandardOutput = true,
UseShellExecute = false,
CreateNoWindow = true
}).WaitForExit();
Console.WriteLine("Hello World!");
}
} |
No description provided.