CompilationDependencyResolver should operate on known list of CSX files #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seesharper
reviewed
Dec 11, 2018
| @@ -74,6 +74,16 @@ private void LogProjectFileInfo(string pathToProjectFile) | |||
|
|
|||
| public string CreateProject(string targetDirectory, string defaultTargetFramework = "net46", bool enableNuGetScriptReferences = false) | |||
There was a problem hiding this comment.
Should we mark this as obsolete too?
There was a problem hiding this comment.
this is actually used by us at runtime so it's needed
seesharper
approved these changes
Dec 11, 2018
I will after we merge 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OmniSharp finds the CSX files once, we can avoid the extra scanning.
Also, OmniSharp allows users to exclude paths from scanning and we should respect that (at the moment we will find those CSX files).
fixes #279