Remove Newtonsoft.Json #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
reviewed
Sep 27, 2022
filipw
approved these changes
Sep 27, 2022
|
when will this change be released? |
|
We will release a new version just about when .Net 7 goes RTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency we have on
Newtonsoft.Jsonand replaces the code withSystem.Text.Json.Newtonsoft.Jsonhas caused quite a few problems over the years since we specify one version indotnet-scriptwhile a script might pull in another version.System.Text.Jsonis pulled in by default when the host isnet6.0ornet7.0.Dotnet.Script.Corealso supportnetstandard2.0and an conditional package-reference has been added forSystem.Text.Json.Note: We are not yet completely free from
Newtonsoft.Jsonyet sinceNuGet.ProjectModelalso has this in its dependency graph, but we have done what we can on thedotnet-scriptside of things and we can close #674 for now.