Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix greedy parsing of load directive part #724

Merged
merged 1 commit into from
May 27, 2023
Merged

Fix greedy parsing of load directive part #724

merged 1 commit into from
May 27, 2023

Conversation

atifaziz
Copy link
Contributor

This PR fixes #720.

It also adds a test to avoid a regression in the future.

@atifaziz atifaziz mentioned this pull request May 22, 2023
Closed
seesharper
seesharper approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great 😃

@seesharper seesharper requested a review from filipw May 22, 2023 12:26
@seesharper seesharper merged commit 703d0fa into dotnet-script:master May 27, 2023
3 checks passed
@atifaziz atifaziz deleted the fix/bug-720 branch June 6, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seesharper seesharper seesharper approved these changes

@filipw filipw Awaiting requested review from filipw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csx parsing problems
2 participants
@atifaziz @seesharper