Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript implementation of balanced trees is broken in 4.1.2 #885

Closed
cata opened this issue Jan 17, 2018 · 3 comments
Closed

JavaScript implementation of balanced trees is broken in 4.1.2 #885

cata opened this issue Jan 17, 2018 · 3 comments
Assignees

Comments

@cata
Copy link
Contributor

cata commented Jan 17, 2018

Removing the first element in a map or set yields and empty map/set.
Repro: http://try.websharper.com/snippet/0000IB

I am unsure if this is the only scenario that breaks.
Update: removing the last element has the same effect

@Tarmil Tarmil added the bug label Jan 17, 2018
@Tarmil Tarmil self-assigned this Jan 17, 2018
Tarmil added a commit that referenced this issue Jan 17, 2018
Also add tests for Remoting returning empty Map and Set
@Tarmil
Copy link
Member

Tarmil commented Jan 17, 2018

Sorry about that, looks like our tests were insufficient.

I reverted 44fcc35 which introduced this issue: it is not needed anymore since we've changed how maps are serialized to JSON. This will be on NuGet very soon.

@Tarmil
Copy link
Member

Tarmil commented Jan 17, 2018

The fix is released on NuGet in v4.1.3.

@cata
Copy link
Contributor Author

cata commented Jan 18, 2018

Thanks @Tarmil !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants