fix possible null #118
Merged
fix possible null #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sammychinedu2ky please review. |
sammychinedu2ky
suggested changes
Feb 25, 2023
Comment on lines
92
to
96
| if(Data == null) | ||
| { | ||
| Assert.Fail("Data null"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I don't think this is necessary since it is a controlled environment. A null-forgiving operator would be better I guess 😅
There was a problem hiding this comment.
Why kill a mosquito with a swatter when you can use a bazooka?
OK, review now.
There was a problem hiding this comment.
Nice line though 😅
sammychinedu2ky
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.