Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample of client-side validation of IClientModelValidator doesn't work #7894

Closed
nicholasyin opened this issue Jul 31, 2018 · 1 comment
Closed

Sample of client-side validation of IClientModelValidator doesn't work #7894

nicholasyin opened this issue Jul 31, 2018 · 1 comment
Assignees
@scottaddie
Labels
Pri0 Urgent priority
Projects
Sprint 139 (July 23- Aug 10) Board View
Milestone
Sprint 139 (July ...

Comments

@nicholasyin
Copy link

nicholasyin commented Jul 31, 2018 •
edited

Full file path needing fix:

aspnetcore\mvc\models\validation\sample\Views\Movies\Create.cshtml

image

Google search result from stackoverflow told me this solution, moving the 2 js functions outside of document ready function. Otherwise the client-side validation won't get fired.
@scottaddie scottaddie self-assigned this Jul 31, 2018
@scottaddie scottaddie added this to To do in Sprint 139 (July 23- Aug 10) Board View via automation Jul 31, 2018
@scottaddie scottaddie added bug Pri0 Urgent priority labels Jul 31, 2018
@scottaddie scottaddie mentioned this issue Jul 31, 2018
Merged
@scottaddie
Copy link
Member

@nicholasyin That jQuery document.ready call can be removed. I've submitted a PR to address this.

@scottaddie scottaddie moved this from To do to In progress in Sprint 139 (July 23- Aug 10) Board View Jul 31, 2018
Sprint 139 (July 23- Aug 10) Board View automation moved this from In progress to Done Jul 31, 2018
scottaddie added a commit that referenced this issue Jul 31, 2018
@scottaddie
Remove unnecessary jQuery document.ready call (#7899)
27e907f 
Fixes #7894

Also incorporated a few Acrolinx suggestions while I was in there.

[Internal Review Page](https://review.docs.microsoft.com/en-us/aspnet/core/mvc/models/validation?view=aspnetcore-2.1&branch=pr-en-us-7899#iclientmodelvalidator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottaddie scottaddie

Labels
Pri0 Urgent priority
Projects
No open projects
Sprint 139 (July 23- Aug 10) Board View
  
Done
Milestone
Sprint 139 (July 23 - Aug 10)
Development

No branches or pull requests
2 participants
@scottaddie @nicholasyin