Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OpenRegion/CloseRegion remark #12546

Merged
merged 1 commit into from
May 28, 2019
Merged

Remove OpenRegion/CloseRegion remark #12546

merged 1 commit into from
May 28, 2019

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented May 26, 2019 •
edited
Loading

Fixes #12544

The remark came from the Gist ...

... split up your code into smaller pieces wrapped in OpenRegion/CloseRegion calls.

https://gist.github.com/SteveSandersonMS/ec232992c2446ab9a0059dd0fbc5d0c3#questions

... but those aren't public ...

https://github.com/aspnet/AspNetCore/blob/master/src/Components/Components/src/RenderTree/RenderTreeBuilder.cs#L537-L552

Thanks @limefrogyank! 🚀

@guardrex guardrex requested a review from danroth27 May 26, 2019 13:12
@guardrex guardrex merged commit 6ab3bda into master May 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the guardrex-patch-1 branch May 28, 2019 22:04
@guardrex guardrex mentioned this pull request Jun 3, 2019
Closed
This was referenced Sep 12, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danroth27 danroth27 danroth27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenRegion/CloseRegion are internal
2 participants
@guardrex @danroth27