Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC Kestrel configuration documentation #14015

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Add gRPC Kestrel configuration documentation #14015

merged 4 commits into from
Aug 28, 2019

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 26, 2019 •
edited

Tratcher
Tratcher reviewed Aug 26, 2019
View reviewed changes
aspnetcore/grpc/aspnetcore.md Outdated Show resolved Hide resolved
aspnetcore/grpc/aspnetcore.md Outdated Show resolved Hide resolved
JamesNK and others added 2 commits August 26, 2019 18:00
@JamesNK @Tratcher
Update aspnetcore/grpc/aspnetcore.md
bf6b93b 
Co-Authored-By: Chris Ross <Tratcher@Outlook.com>
@JamesNK
PR feedback
8670fbe
halter73
halter73 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice if one of the samples should load a cert from the store, but I don't feel strongly about it.

shirhatti
shirhatti approved these changes Aug 27, 2019
View reviewed changes
aspnetcore/grpc/aspnetcore.md Show resolved Hide resolved
@JamesNK
Copy link
Member Author

JamesNK commented Aug 28, 2019

@guardrex @scottaddie @Rick-Anderson Ready for language review and merge 🙏

@guardrex
Copy link
Collaborator

guardrex commented Aug 28, 2019 •
edited

No worries ... I see it. The whole topic is 3.0.

Sorry ... my bad ... I'm neck deep in Blazor security stuff. 😄

guardrex
guardrex approved these changes Aug 28, 2019
View reviewed changes
Copy link
Collaborator

@guardrex guardrex left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The combined tab failure is a known false positive.

@guardrex guardrex merged commit 37a490c into master Aug 28, 2019
@guardrex guardrex deleted the jamesnk/grpc-kestrel branch August 28, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@halter73 halter73 halter73 approved these changes

@guardrex guardrex guardrex approved these changes

@shirhatti shirhatti shirhatti approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JamesNK @guardrex @halter73 @Tratcher @shirhatti