Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AccountController.cs #14054

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Update AccountController.cs #14054

merged 1 commit into from
Aug 28, 2019

Conversation

allanchua101
Copy link
Contributor

  • Fixed comment to indicate code execution instead of using the word "we".

- Fixed comment to indicate code execution instead of using the word we.
Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allanchua101 ... fyi ... we DO use contractions, so "doesn't" is ok. The "got this far" bit probably could say "reached this point," but that's also no big deal. Code comments are frequently a bit loose when it comes to grammar+style.

@guardrex
Copy link
Collaborator

Before I merge this, I'll check the associated topic. I don't see snippets here, but the topic may have ranges in it for code examples from the file. We have to make sure that line changes wouldn't break line highlighting.

@guardrex
Copy link
Collaborator

There's only one snippet here, and it isn't associated with these lines. We're good.

@guardrex guardrex merged commit 4b9e18d into dotnet:master Aug 28, 2019
@allanchua101
Copy link
Contributor Author

Thanks @guardrex 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants